Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI][API10] Do not register events if disposed ImagView changed #5357

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[NUI][API10] Do not register events if disposed ImagView changed #5357

merged 1 commit into from
Jun 27, 2023

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Jun 26, 2023

No description provided.

@github-actions github-actions bot added the API10 Platform : Tizen 7.0 / TFM: tizen10.0 label Jun 26, 2023
@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/public/BaseComponents/ImageView.cs(1392,35): error CS7036: There is no argument given that corresponds to the required formal parameter 'message' of 'Log.Error(string, string, string, string, int)' [src/Tizen.NUI/Tizen.NUI.csproj]

dongsug-song
dongsug-song approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@hinohie hinohie merged commit c43de73 into Samsung:API10 Jun 27, 2023
3 checks passed
@hinohie hinohie deleted the throw_dead_image_api10 branch June 27, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsug-song dongsug-song dongsug-song approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

Assignees
No one assigned
Labels
API10 Platform : Tizen 7.0 / TFM: tizen10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinohie @TizenAPI-Bot @dongsug-song